fixing incorrect status on failed tiles #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanbirAulakh
approved these changes
Nov 3, 2023
edparris
reviewed
Nov 3, 2023
| @@ -90,7 +90,7 @@ def process_tiles( | |||
| raster_dataset: gdal.Dataset, | |||
| metrics: MetricsLogger = None, | |||
| sensor_model: Optional[SensorModel] = None, | |||
| ) -> int: | |||
| ) -> Tuple[int, int]: | |||
There was a problem hiding this comment.
NIT: Update docstring to match new return type.
There was a problem hiding this comment.
I'll add this to the unit test follow up PR as well
edparris
reviewed
Nov 3, 2023
| region_status = RegionRequestStatus.SUCCESS | ||
| if total_tile_count == tile_error_count: | ||
| region_status = RegionRequestStatus.FAILED | ||
| if tile_error_count > 0 and tile_error_count > total_tile_count: |
There was a problem hiding this comment.
The second half of this if statement looks broken. When would the tile_error_count ever be greater than the total_tile_count? Wouldn't this function default to SUCCESS for a failure count > 0 but less than the total_tile_count?
There was a problem hiding this comment.
yeah, the last line of that should be if tile_error_count > 0 and tile_error_count < total_tile_count. I'll fix that in the unit test PR. I was planning to add a test specifically for his function anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
fixing case where status monitor shows success when tiles fail and updating tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.