Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating ts loadbalancer to use VPC settings #160

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

drduhe
Copy link
Collaborator

@drduhe drduhe commented Jan 24, 2025

Issue #, if available: n/a

Notes

  • Updating the TSDataplane construct to correctly import VPC settings for creating the load balancer for the FargateService.
  • Adding configuration parameter to OSMLVpc Construct to allow turning provisioning of VPC endpoints off.
  • Updating package dependencies to resolve security findings for old versions of dependancies.
  • Fixing depreciated function calls brought about by version bumps.

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Jan 24, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.67% (+0.04% 🔼)
622/686
🔴 Branches
56.57% (+0.18% 🔼)
99/175
🟢 Functions 96.3% 52/54
🟢 Lines
90.67% (+0.04% 🔼)
622/686
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ts_dataplane.ts
86.59% (+0.34% 🔼)
52% (-0.17% 🔻)
100%
86.59% (+0.34% 🔼)

Test suite run success

24 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 4cee9bb

@drduhe drduhe force-pushed the fix/update-ts-loadbalancer branch from 26dc77f to b0bda4e Compare January 24, 2025 19:07
@drduhe drduhe force-pushed the fix/update-ts-loadbalancer branch from b0bda4e to 4cee9bb Compare January 24, 2025 19:18
@drduhe drduhe merged commit c735747 into main Jan 24, 2025
2 checks passed
@drduhe drduhe deleted the fix/update-ts-loadbalancer branch January 24, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants