Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove firelens references #146

Merged
merged 1 commit into from
Aug 26, 2024
Merged

chore: remove firelens references #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/osml/model_runner/roles/mr_execution_role.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ export class MRExecutionRole extends Construct {
constructor(scope: Construct, id: string, props: MRExecutionRoleProps) {
super(scope, id);

const firelensLogGroupName = `/aws/${
new MRDataplaneConfig().CW_METRICS_NAMESPACE
}/MRFireLens`;
const serviceLogGroupName = `/aws/${
new MRDataplaneConfig().CW_METRICS_NAMESPACE
}/MRService`;
Expand Down Expand Up @@ -100,7 +97,6 @@ export class MRExecutionRole extends Construct {
"logs:CreateLogGroup"
],
resources: [
`arn:${this.partition}:logs:${props.account.region}:${props.account.id}:log-group:${firelensLogGroupName}:*`,
`arn:${this.partition}:logs:${props.account.region}:${props.account.id}:log-group:${serviceLogGroupName}:*`
]
})
Expand Down
2 changes: 0 additions & 2 deletions lib/osml/model_runner/roles/mr_task_role.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ export class MRTaskRole extends Construct {
this.mrDataplaneConfig.DDB_ENDPOINT_PROCESSING_TABLE;
const DDB_REGION_REQUEST_TABLE_NAME =
this.mrDataplaneConfig.DDB_REGION_REQUEST_TABLE;
const MR_FIRELENS_LOG_GROUP_NAME = `/aws/${this.mrDataplaneConfig.CW_METRICS_NAMESPACE}/MRFireLens`;
const MR_SERVICE_LOG_GROUP_NAME = `/aws/${this.mrDataplaneConfig.CW_METRICS_NAMESPACE}/MRService`;
const MR_HTTPENDPOINT_LOG_GROUP_NAME = `/aws/${this.mrDataplaneConfig.CW_METRICS_NAMESPACE}/HTTPEndpoint`;

Expand Down Expand Up @@ -240,7 +239,6 @@ export class MRTaskRole extends Construct {
"logs:CreateLogGroup"
],
resources: [
`arn:${this.partition}:logs:${props.account.region}:${props.account.id}:log-group:${MR_FIRELENS_LOG_GROUP_NAME}:*`,
`arn:${this.partition}:logs:${props.account.region}:${props.account.id}:log-group:${MR_SERVICE_LOG_GROUP_NAME}:*`,
`arn:${this.partition}:logs:${props.account.region}:${props.account.id}:log-group:${MR_HTTPENDPOINT_LOG_GROUP_NAME}:*`,
`arn:${this.partition}:logs:${props.account.region}:${props.account.id}:log-group:/aws/sagemaker/Endpoints/*`
Expand Down
Loading