Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Java and Gradle version in Android sample #34

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yq-yang-qin
Copy link
Collaborator

Description

  • Bump Java and Gradle version in Android sample

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

@zxkane zxkane requested a review from zhu-xiaowei December 14, 2024 15:13
@zhu-xiaowei
Copy link
Contributor

For build-android actions, Please fix the build error:

error: invalid source release: 21

For the build-ios actions, Please update the runs-on parameter in
https://github.com/aws-samples/swift-chat/actions/runs/12339018149/workflow#L11,
https://github.com/aws-samples/clickstream-sdk-samples/blob/main/.github/workflows/build-rn.yml#L37
to macos-latest and try again.

@yq-yang-qin yq-yang-qin changed the title Bump Java and Gradle version in Android sample chore: bump Java and Gradle version in Android sample Jan 6, 2025
@yq-yang-qin
Copy link
Collaborator Author

@zhu-xiaowei, thanks for the comment, I've successfully updated the Build for Android and Build for iOS workflow actions. However, my PR is now encountering issues in the Build for React Native workflow:

The build-ios action within the React Native workflow is failing with the error "Error installing boost: Verification checksum was incorrect". This is an open issue in the Boost package, requiring manual intervention to fix the checksum link in boost.podspec file.

The build-android action is failing due to a compileSdkVersion issue.

Given that my PR doesn't modify anything in the Clickstream React Native SDK example, and these failures are unrelated to my tests on the Android SDK, would it be acceptable to proceed with merging the PR despite these React Native action failures?

@zhu-xiaowei
Copy link
Contributor

This PR indeed does not modify ReactNative code, it only makes changes to the Android Sample, I think this PR can be merged first.
Regarding the ReactNative build failures, they appear to be related to the GitHub action build environment upgrades of ubuntu-latest and macos-latest. Suggest fixing these issues in a new PR.

@yq-yang-qin yq-yang-qin enabled auto-merge (squash) February 7, 2025 17:10
@yq-yang-qin yq-yang-qin disabled auto-merge February 7, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants