Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support keycloak clustered deployment using JDBC_PING for quarkus distribution #210

Merged
merged 8 commits into from
Oct 17, 2023
Merged

feat: support keycloak clustered deployment using JDBC_PING for quarkus distribution #210

merged 8 commits into from
Oct 17, 2023

Conversation

hpp222
Copy link
Contributor

@hpp222 hpp222 commented Oct 16, 2023 •
edited
Loading

Fixes #199

  • Quarkus version is deployable by using JDBC_PING discovery protocol
  • keycloak version 22.0.4 tested in 5 regions: us-east-1, us-west-2, ap-southeast-1, cn-north-1, cn-northwest-1

@hpp222 hpp222 changed the title support keycloak clustered deployment using JDBC_PING for quarkus distribution feat: support keycloak clustered deployment using JDBC_PING for quarkus distribution Oct 16, 2023
wchaws
wchaws requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@wchaws wchaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some description about this PR which aws regions did you test.

src/keycloak.ts Show resolved Hide resolved
src/keycloak.ts Show resolved Hide resolved
entryPoint.txt Outdated Show resolved Hide resolved
src/keycloak.ts Outdated Show resolved Hide resolved
src/keycloak.ts Outdated Show resolved Hide resolved
@hpp222 hpp222 requested a review from wchaws October 16, 2023 13:45
wchaws
wchaws approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@wchaws wchaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wchaws wchaws merged commit 1b33a79 into aws-samples:main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchaws wchaws wchaws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quarkus versions not deployable (keycloak > 16)
2 participants
@hpp222 @wchaws