added my-widget-service for Python #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ecs typescript examples to v0.36.1
TomDufall
suggested changes
Jul 3, 2019
python/my-widget-service/my_widget_service/my_widget_service.egg-info/PKG-INFO
Outdated
Show resolved
Hide resolved
python/my-widget-service/my_widget_service/my_widget_service.egg-info/SOURCES.txt
Outdated
Show resolved
Hide resolved
python/my-widget-service/my_widget_service/my_widget_service.egg-info/dependency_links.txt
Outdated
Show resolved
Hide resolved
python/my-widget-service/my_widget_service/my_widget_service.egg-info/requires.txt
Outdated
Show resolved
Hide resolved
python/my-widget-service/my_widget_service/my_widget_service.egg-info/top_level.txt
Outdated
Show resolved
Hide resolved
python/my-widget-service/my_widget_service/my_widget_service_stack.py
Outdated
Show resolved
Hide resolved
python/my-widget-service/my_widget_service/my_widget_service_stack.py
Outdated
Show resolved
Hide resolved
* WIP: Updating Python examples to 0.36.1 * Adding some ECS examples * Adding more ECS examples * Adding final ECS examples
|
I don't quite understand the build failure. it appears to be npm related and not something I can fix in this commit, is this correct? |
|
Yeah, I don't think it's related to your changes and I don't think there is anything you can do to fix it in this PR. |
|
Is there a way to re-run the tests without pushing another commit? The build was broken when I submitted the change, but the build has been fixed and the test hasn't re-run. |
|
I'm getting merge conflicts when I try to merge locally. Could we rebase this and see where we stand? |
|
Yes. Absolutely. I’ll rebase it today and check on the None.None error
… On Sep 17, 2019, at 1:02 PM, Mitch Garnaat ***@***.***> wrote:
I'm getting merge conflicts when I try to merge locally. Could we rebase this and see where we stand?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@garnaat this example looks completely broken. I'm okay re-writing it for CDK 1.8 and submitting a fresh PR. |
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
*Description of changes: Created a version of the MyWidgetService that uses API Gateway Service Integrations to directly interact with S3.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.