Fix issue where HOSTS_VERSION was incompatible with packages not using webpack #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g webpack. We were setting the HOSTS_VERSION at build time using webpack. We also want customers who want to use modules/not use our webpack build to be able to do so. These are incompatible. To solve this, we are now writing out the version number into source at release time. This should have the same effect as before, anyone using an NPM release will get a version number, otherwise you will have 'development'. I tested this in a release in my fork, you can see the overwritten file here in the artifacts: https://github.com/prestomation/amazon-sumerian-hosts/actions/runs/3301290701
eherozhao
approved these changes
Oct 24, 2022
JuliaABurch
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the HOSTS_VERSION at build time using webpack.
We also want customers who want to use modules/not use our webpack build to be able to do so.
These are incompatible.
To solve this, we are now writing out the version number into source at release time. This should have the same effect as before, anyone using an NPM release will get a version number, otherwise you will have 'development'.
I tested this in a release in my fork, you can see the overwritten file here in the artifacts: https://github.com/prestomation/amazon-sumerian-hosts/actions/runs/3301290701
Related Issue #133
Reviewer Testing Instructions
Can't completely test without creating a release.
After this is merged we will perform a release and test our repro cases to fully test
Submission Checklist
I confirm that I have...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.