Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/peer dependency #946

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Feature/peer dependency #946

merged 6 commits into from
Mar 12, 2024

Conversation

shapirov103
Copy link
Collaborator

Issue #, if available: #944

Description of changes: CDK dependency is set as peerDependencies to allow for smoother installation and upgrade process. Documentation (Getting started) updated for common troubleshooting cases when installing and upgrading.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

elamaran11
elamaran11 previously approved these changes Mar 11, 2024
Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the peer dependency documentation.

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

…moved flux example as it was failing to compile
@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11 elamaran11 merged commit 899f9e3 into main Mar 12, 2024
2 checks passed
@shapirov103 shapirov103 deleted the feature/peer-dependency branch June 28, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants