Added configuration value enableWindowsIpam for Vpc-cni add on #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renukakrishnan
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
reviewed
Feb 23, 2024
There was a problem hiding this comment.
@renukakrishnan Thankyou for the PR.Please update the docs too.
lib/addons/vpc-cni/index.ts
Outdated
| @@ -436,7 +443,8 @@ function populateVpcCniConfigurationValues(props?: VpcCniAddOnProps): Values { | |||
| WARM_IP_TARGET: props?.warmIpTarget, | |||
| WARM_PREFIX_TARGET: props?.warmPrefixTarget, | |||
| }, | |||
| enableNetworkPolicy: JSON.stringify(props?.enableNetworkPolicy) | |||
| enableNetworkPolicy: JSON.stringify(props?.enableNetworkPolicy), | |||
| enableWindowsIpam:JSON.stringify(props?.enableWindowsIpam) | |||
There was a problem hiding this comment.
Space is missing after :
There was a problem hiding this comment.
@elamaran11 Updated the docs and added space.
elamaran11
approved these changes
Feb 23, 2024
|
@shapirov103 LGTM. Feel free to merge this. The markdown failure is from Kubecost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added and exposed the configuration for "enableWindowsIpam" for the vpc-cni add on. This will allow to turn on the configuration value for Windows EKS clusters while using the Windows patterns.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.