Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #916 #922

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fixes #916 #922

merged 2 commits into from
Feb 13, 2024

Conversation

shapirov103
Copy link
Collaborator

Issue #, if available: #916

Description of changes:
Import cluster provider can handle cluster name as token.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator Author

@elamaran11 please review

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment!

lib/utils/id-utils.ts Show resolved Hide resolved
@shapirov103
Copy link
Collaborator Author

@elamaran11 addressed review comments

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit 26bc12d into main Feb 13, 2024
1 check passed
@shapirov103 shapirov103 deleted the bug/import-cluster-provider-token-failure branch June 28, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants