Fargate with CoreDNS Addon - Retain on Delete #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Howlla
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
reviewed
Jan 9, 2024
shapirov103
reviewed
Jan 9, 2024
lib/addons/core-addon/index.ts
Outdated
| * https://github.com/aws/aws-cdk/issues/28621 | ||
| * */ | ||
|
|
||
| if(clusterInfo.cluster instanceof FargateCluster && this.coreAddOnProps.addOnName === "coredns"){ |
There was a problem hiding this comment.
the rule of software engineering is to avoid making more abstract (parent) dependent on private logic specific to just one of the subclasses. Can we move this fix to coredns addon? We can just call super there get the instance of the cfnAddOn to add dependency.
There was a problem hiding this comment.
Thanks for the recommendation @shapirov103.
Made the changes recommended
shapirov103
reviewed
Jan 9, 2024
lib/addons/coredns/index.ts
Outdated
| * Retain the addon otherwise cluster destroy will fail due to CoreDnsComputeTypePatch | ||
| * https://github.com/aws/aws-cdk/issues/28621 | ||
| */ | ||
| handleFargatePatch( addonPromise: Promise<Construct> ): Promise<Construct> { |
There was a problem hiding this comment.
You don't need to return anything here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Relates to CDK
Description of changes:
Apply Retain on Delete policy for CoreDns Addon.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.