Change to use eks.nodeGroupOptions in the builder #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROunofF
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
ROunofF
changed the title
elamaran11
reviewed
Dec 21, 2023
| maxSize: options.maxNodeSize, | ||
| nodeRole: options.nodeRole, | ||
| nodeGroupSubnets: { subnetType: ec2.SubnetType.PRIVATE_WITH_EGRESS }, | ||
| diskSize: options.blockDeviceSize, |
There was a problem hiding this comment.
Why is this property removed?
| function buildGenericNodeGroup(options: WindowsOptions, overrideOptions?: eks.NodegroupOptions): clusterproviders.ManagedNodeGroup { | ||
|
|
||
| let currentOptions = options.genericNodeGroupOptions; | ||
| if ( overrideOptions ) { currentOptions = merge(options.genericNodeGroupOptions, overrideOptions) } | ||
|
|
||
| return { |
There was a problem hiding this comment.
Please fix the GH action issue
elamaran11
reviewed
Dec 21, 2023
| function buildGenericNodeGroup(options: WindowsOptions, overrideOptions?: eks.NodegroupOptions): clusterproviders.ManagedNodeGroup { | ||
|
|
||
| let currentOptions = options.genericNodeGroupOptions; | ||
| if ( overrideOptions ) { currentOptions = merge(options.genericNodeGroupOptions, overrideOptions) } |
shapirov103
reviewed
Feb 5, 2024
There was a problem hiding this comment.
@ROunofF please address the minor feedback (inline) I will test and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Change to use eks.nodeGroupOptions so we can have all options override in case it's needed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.