Provision add custom security group to secondary eni in vpc cni addon custom networking #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineetjp
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
reviewed
Dec 17, 2023
|
Looks great, provide e2e tests pass. |
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: The current implementation of eniconfig manifest creation by default sets the eks cluster's security group id as secondary eni id. If a user wants to use an already existing security group id then its not possible now
Description of changes:
Provides capability to specify an existing security group for EniConfig generated by vpc cni addon. The security group id is optional in CustomNetworkingConfig, if security group is not specified cluster security group id will be used.
This change is in reference to the Custom Networking documentation steps which specifies "Replace $cluster_security_group_id with the ID of an existing security group that you want to use for each ENIConfig."
https://docs.aws.amazon.com/eks/latest/userguide/cni-custom-network.html#custom-networking-configure-kubernetes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.