Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon EKS Pod Identity Agent add-on #884

Merged

Conversation

vumdao
Copy link
Contributor

@vumdao vumdao commented Dec 6, 2023

Issue #, if available:
Amazon EKS introduces EKS Pod Identity, a new feature that simplifies how cluster administrators can configure Kubernetes applications to obtain AWS IAM permissions. These permissions can now be easily configured with fewer steps directly through EKS console, APIs, and CLI. EKS Pod Identity makes it easy to use an IAM role across multiple clusters and simplifies policy management by enabling the reuse of permission policies across IAM roles.

Description of changes:
Add Amazon EKS Pod Identity Agent add-on

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator

I know it is not your area, but there is a failure on markdown check of external links in Karpenter that we will need to fix before this can be merged. @youngjeong46 can you look into the GH action failure above?

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@youngjeong46
Copy link
Collaborator

I know it is not your area, but there is a failure on markdown check of external links in Karpenter that we will need to fix before this can be merged. @youngjeong46 can you look into the GH action failure above?

will take a look shortly.

@youngjeong46
Copy link
Collaborator

@shapirov103 pushed a quick PR here: #885

However, I checked one of the links, and this one works: https://charts.karpenter.sh . Any way to bypass this one? If not, I can remove the link.

@shapirov103
Copy link
Collaborator

shapirov103 commented Dec 6, 2023

@shapirov103 pushed a quick PR here: #885

However, I checked one of the links, and this one works: https://charts.karpenter.sh . Any way to bypass this one? If not, I can remove the link.

@youngjeong46 please see my comment on #885. If the link works it should not be failing unless it is a temporary failure. We can either retry the GH action or we can add links to the exclude list here .github/workflows/linkcheck.json.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vumdao Looks great, thank you for this contribution!

@shapirov103 shapirov103 merged commit b6206bb into aws-quickstart:main Dec 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants