Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing efs policy statements DescribeAvailabilityZones, Descr… #882

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

daniel-pebble
Copy link
Contributor

This PR aligns the efs provider IAM policy with the reference policy found here
https://raw.githubusercontent.com/kubernetes-sigs/aws-efs-csi-driver/master/docs/iam-policy-example.json

Without this, when provisioning a dynamic volume the user may see this error.

image

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @shapirov103 Please check and run e2e

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator

@elamaran11 it maybe unrelated to the applied code change but I am getting the following error on e2e:

blueprint-construct-dev | 10:03:24 PM | CREATE_FAILED | Custom::AWSCDK-EKS-KubernetesResource | blueprint-construct-dev/adot-collector-sa/manifest-adot-collector-saServiceAccountResource/Resource/Default (blueprintconstructdevadotcollectorsamanifestadotcollectorsaServiceAccountResourceA34512D7) Received response status [FAILED] from custom resource. Message returned: Error: b'Error from server (NotFound): error when creating "/tmp/manifest.yaml": namespaces "adot" not found\n'

Do we have dependencies properly defined in ADOT?

@shapirov103
Copy link
Collaborator

/do-e2e-tests

@elamaran11
Copy link
Collaborator

@elamaran11 it maybe unrelated to the applied code change but I am getting the following error on e2e:

blueprint-construct-dev | 10:03:24 PM | CREATE_FAILED | Custom::AWSCDK-EKS-KubernetesResource | blueprint-construct-dev/adot-collector-sa/manifest-adot-collector-saServiceAccountResource/Resource/Default (blueprintconstructdevadotcollectorsamanifestadotcollectorsaServiceAccountResourceA34512D7) Received response status [FAILED] from custom resource. Message returned: Error: b'Error from server (NotFound): error when creating "/tmp/manifest.yaml": namespaces "adot" not found\n'

Do we have dependencies properly defined in ADOT?

I dont think we have touched ADOT in a while. Let me take a closer look tomorrow.

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shapirov103
Copy link
Collaborator

merging, will address any issues after moving to CDK 2.114 and EKS 1.28

@shapirov103 shapirov103 dismissed aws-ia-ci’s stale review December 12, 2023 21:24

will be addressed in the next PR

@shapirov103 shapirov103 merged commit 29f9c0b into aws-quickstart:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants