fix: 869, support for non default namespace for adot #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrajb
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
elamaran11
previously approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM. @shapirov103 Can you review and run e2e. This is for a issue reported.
shapirov103
reviewed
Nov 9, 2023
lib/addons/adot/index.ts
Outdated
| @@ -25,22 +27,37 @@ const defaultProps = { | |||
| @supportsALL | |||
| export class AdotCollectorAddOn extends CoreAddOn { | |||
|
|
|||
| private namespace: string; | |||
There was a problem hiding this comment.
we try to avoid member variable other than the props, since blueprints can be cloned an reused.
You can drop line 39 and just use in the deploy method this.coreAddOnProps.namespace
There was a problem hiding this comment.
Updated the code, was able to test successfully as well
k get all -n adot [10/11/23| 8:47AM]
NAME READY STATUS RESTARTS AGE
pod/otel-collector-amp-collector-748d886bdd-kp6bp 1/1 Running 0 11h
pod/otel-collector-xray-collector-c76d86886-gxmq4 1/1 Running 0 11h
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/otel-collector-amp-collector-monitoring ClusterIP 172.20.126.84 <none> 8888/TCP 11h
service/otel-collector-xray-collector ClusterIP 172.20.205.87 <none> 4317/TCP,4318/TCP 11h
service/otel-collector-xray-collector-headless ClusterIP None <none> 4317/TCP,4318/TCP 11h
service/otel-collector-xray-collector-monitoring ClusterIP 172.20.96.232 <none> 8888/TCP 11h
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/otel-collector-amp-collector 1/1 1 1 11h
deployment.apps/otel-collector-xray-collector 1/1 1 1 11h
NAME DESIRED CURRENT READY AGE
replicaset.apps/otel-collector-amp-collector-748d886bdd 1 1 1 11h
replicaset.apps/otel-collector-xray-collector-c76d86886 1 1 1 11h
elamaran11
reviewed
Nov 10, 2023
|
/do-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #869
Description of changes:
Adds support for non-default namespace for ADOT deployment.
Tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.