-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed tests, build issues, upgraded CDK and libs #1084
Conversation
/do-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests failed. A maintainer can provide more details.
@elamaran11 the e2e tests were success but due to the ipv6 cluster it took over two hours to create/destroy, hence failed. Please review and merge at your convenience. This is needed to merge other PRs that are currently failing on tests and build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shapirov103 Changes look great. Only concern though is on the reoccurrence of this issue with all future e2e's. Could we do another e2e run before merge?
There is not much I can do other than temporarily remove ipv6 test to prevent timeout. The plan was to move to ABP. |
/do-e2e-tests |
Sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests passed
Issue #, if available:
Description of changes: In prep for the release fixing test and libs to merge the pull request that are currently in the queue.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.