Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests, build issues, upgraded CDK and libs #1084

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

shapirov103
Copy link
Collaborator

Issue #, if available:

Description of changes: In prep for the release fixing test and libs to merge the pull request that are currently in the queue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests failed. A maintainer can provide more details.

@shapirov103
Copy link
Collaborator Author

@elamaran11 the e2e tests were success but due to the ipv6 cluster it took over two hours to create/destroy, hence failed. Please review and merge at your convenience. This is needed to merge other PRs that are currently failing on tests and build.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shapirov103 Changes look great. Only concern though is on the reoccurrence of this issue with all future e2e's. Could we do another e2e run before merge?

@shapirov103
Copy link
Collaborator Author

@shapirov103 Changes look great. Only concern though is on the reoccurrence of this issue with all future e2e's. Could we do another e2e run before merge?

There is not much I can do other than temporarily remove ipv6 test to prevent timeout. The plan was to move to ABP.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

@elamaran11
Copy link
Collaborator

@shapirov103 Changes look great. Only concern though is on the reoccurrence of this issue with all future e2e's. Could we do another e2e run before merge?

There is not much I can do other than temporarily remove ipv6 test to prevent timeout. The plan was to move to ABP.

Sounds good.

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@elamaran11 elamaran11 merged commit 5d5eef7 into main Oct 14, 2024
2 checks passed
@elamaran11 elamaran11 deleted the task/1.16.0-release-prep branch October 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants