Feature/kubeshark #1003
Feature/kubeshark #1003
Conversation
adding kubeshark feature
updating index with kubeshark
zghanem0
requested review from
aws-ia-ci,
parkand1,
shapirov103,
youngjeong46,
elamaran11 and
a team
as code owners
There was a problem hiding this comment.
@zghanem0 Firstly thankyou so much for the PR. Very good addon that can be added to blueprints. Before i dive deep in to the PR. Following essential things are missing as part of minimum criteria:
- Doc
index.mdis not updated with your for getting listed in Addons list mkdocs.yamlis not updated with your new addon for doc website- E2E blueprints example stack is not updated with your addon. Make sure to update the blueprints stack with your addon for E2E and also run the E2E once locally.
- Make sure you add new unit tests for your addon. Once done let me know i can review again.
adding kubeshark in the index
adding kubeshark doc
There was a problem hiding this comment.
@zghanem0 Great work, need some minor changes in both PRS, before i can test and merge this.
|
@zghanem0 Please fix the index file removal issue so that fixes GH action error. Once done fixing all issues in both PRs let me know. I will run E2E, review and then can merge. Nice work and thankyou for hanging in there. We have a very rigorous review process. Awesome progress. |
This reverts commit 06fef31.
|
Fix the GitHub action errors. |
|
@zghanem0 Only concern at this point for merging this PR is, the addon is currently in your private org, so we want to know who will maintain the Kubeshark addon if its in your private repo, whats your path to move the addon to a public org like |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.