Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): fix doc typos and apply basic lint recommendations #444

Merged
merged 6 commits into from
Jan 13, 2022
Merged

chore(all): fix doc typos and apply basic lint recommendations #444

merged 6 commits into from
Jan 13, 2022

Conversation

michaelbrewer
Copy link
Contributor

Description of your changes

  • Simplify comparisons
  • Fix gramma or spelling on doc strings
  • Fix doc string typos

How to verify this change

Run pre commit and post commit hooks

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@michaelbrewer
chore(all): fix doc typos and apply basic lint recommendations
85addea 
- Simplify comparisons
- Fix gramma or spelling on doc strings
- Fix doc string typos
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 7, 2022
dreamorosi
dreamorosi previously approved these changes Jan 10, 2022
View reviewed changes
packages/tracing/src/Tracer.ts Outdated Show resolved Hide resolved
@dreamorosi dreamorosi added the all label Jan 10, 2022
@dreamorosi dreamorosi requested a review from ijemmy January 10, 2022 09:48
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 10, 2022
@dreamorosi dreamorosi requested a review from saragerion January 10, 2022 13:09
dreamorosi
dreamorosi approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

dreamorosi
dreamorosi requested changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes

packages/tracing/src/Tracer.ts Outdated Show resolved Hide resolved
packages/tracing/src/Tracer.ts Outdated Show resolved Hide resolved
@dreamorosi
Copy link
Contributor

@michaelbrewer sorry for the double review, I was looking at it again and noticed two lines that I think need attention.

Michael Brewer and others added 3 commits January 12, 2022 10:22
@michaelbrewer @dreamorosi
fix: Update packages/tracing/src/Tracer.ts
07e982f 
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
@michaelbrewer @dreamorosi
fix: Update packages/tracing/src/Tracer.ts
ffb0870 
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
@michaelbrewer
Merge branch 'awslabs:main' into chore-housekeeping
4df19a7
@michaelbrewer
Copy link
Contributor Author

@michaelbrewer sorry for the double review, I was looking at it again and noticed two lines that I think need attention.

sorry i probably messed up with doing the merge conflicts. It should be fine now.

@dreamorosi dreamorosi requested review from dreamorosi and removed request for dreamorosi January 12, 2022 18:36
@dreamorosi dreamorosi merged commit 57e0d8f into aws-powertools:main Jan 13, 2022
@michaelbrewer michaelbrewer deleted the chore-housekeeping branch January 13, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

@flochaz flochaz flochaz approved these changes

@ijemmy ijemmy Awaiting requested review from ijemmy

@saragerion saragerion Awaiting requested review from saragerion

Assignees

@michaelbrewer michaelbrewer

Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
production-ready-release
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbrewer @dreamorosi @flochaz