-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(logger): reduce node_modules size #427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
added
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
logger
This item relates to the Logger Utility
labels
Jan 6, 2022
dreamorosi
changed the title
deps(logger): Reduce node_modules size
build(logger): reduce node_modules size
Jan 6, 2022
saragerion
previously approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From 139M to 1.8M! Can't wait to have this one released 🚀
well done!!
…On Thu, Jan 6, 2022, 21:37 Sara Gerion ***@***.***> wrote:
***@***.**** approved this pull request.
From 139M to 1.8M! Can't wait to have this one released 🚀
—
Reply to this email directly, view it on GitHub
<#427 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJLIUOQ5CTPP367W5VY5JTUUX4SLANCNFSM5LNAEJ5A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID:
***@***.***
.com>
|
thanks @dreamorosi |
ijemmy
previously approved these changes
Jan 7, 2022
Need to merge #440 before this can be merged, checks fail because of same linting issue. |
Ready to be reviewed again, all checks passing now. |
flochaz
approved these changes
Jan 7, 2022
saragerion
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
logger
This item relates to the Logger Utility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As detailed in #419 the size of
node_modules
for logger was unnecessarily big, this PR removes the fulllodash
lib in favor of targetedlodash.x
depenencies brigning down thenode_modules
size to1.8M
from139M
.Detailed list of changes:
lodash
&@types/lodash
lodash.clonedeep
,lodash.merge
, andlodash.pickby
& respective@types/lodash.xxx
merge
in mainLogger
class since it was using thelodash/fp
version that swaps the argument order.npm-shrinkwrap.json
forpackages-lock.json
since it was the last utility to still use it.How to verify this change
logger
to check that there are no regressions.npm pack
du -sh *
to measurenode_moduels
size(see screenshot below for steps 3 & 4)
Related issues, RFCs
#419
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.