Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Fix linting issue and add linting to the pre-push hook #440

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Jan 7, 2022

Description of your changes

  1. Fix linting issue that is breaking the build > https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/1666735269
  2. Add pre-push hook to run linting

How to verify this change

npm run lerna-lint

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the bug Something isn't working label Jan 7, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this.

@dreamorosi dreamorosi merged commit e7bc53c into main Jan 7, 2022
@dreamorosi dreamorosi deleted the fix/lintFuncOrder branch January 7, 2022 13:36
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 7, 2022
@dreamorosi dreamorosi added the automation This item relates to automation label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants