Skip to content

Commit

Permalink
fix(metrics): deduplicate dimensions when serialising (#1780)
Browse files Browse the repository at this point in the history
* fix: deduplicate dimensions when serializing

* fix tests

* remove tsbuildinfo

* remove whitespace

* fix gitignore again

* play some sonar games

* fix test
  • Loading branch information
am29d authored and dreamorosi committed Jan 27, 2024
1 parent 936794a commit 4168a44
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions packages/metrics/tests/unit/Metrics.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,11 @@ describe('Class: Metrics', () => {
});

// Act
<<<<<<< HEAD
metrics.addMetric(testMetric, MetricUnit.Count, 10);
=======
metrics.addMetric(testMetric, MetricUnits.Count, 10);
>>>>>>> 9b9fc927 (fix(metrics): deduplicate dimensions when serialising (#1780))
metrics.addDimension('foo', 'baz');
const loggedData = metrics.serializeMetrics();

Expand All @@ -1543,7 +1547,11 @@ describe('Class: Metrics', () => {
Metrics: [
{
Name: testMetric,
<<<<<<< HEAD
Unit: MetricUnit.Count,
=======
Unit: MetricUnits.Count,
>>>>>>> 9b9fc927 (fix(metrics): deduplicate dimensions when serialising (#1780))
},
],
Namespace: TEST_NAMESPACE,
Expand Down

0 comments on commit 4168a44

Please sign in to comment.