Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Support for external observability providers - Metrics #2343

Closed
wants to merge 5 commits into from

Conversation

roger-zhangg
Copy link
Member

@roger-zhangg roger-zhangg commented May 30, 2023

Issue number:
2015

Related to PR

PR feat(metrics): support metrics provider #2194

Summary

Add two base classes for supporting customer to bring their own provider class for observability providers
Added a Datadog provider (draft)

Changes

Add two class in metrics/provider
Implemented Datadog provider using the base Metric class.

User experience

UX is not affected for user using cloudwatch emf format.
Customer can now bring their own metric provider to sent metrics to other observability provider

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 30, 2023
@github-actions github-actions bot added the feature New feature or functionality label May 30, 2023
@roger-zhangg
Copy link
Member Author

Drafted a new metrics provider PR because this approach is much different than the previous provider solution. Will move back to the original PR once details/discussion has settled.
To discuss:

  • Is this design accurate based on our previous discussions.
  • Is provider doing too little in this new design, how to add more user-value to provider

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -1.32 ⚠️

Comparison is base (8b71185) 97.18% compared to head (de7eb16) 95.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2343      +/-   ##
===========================================
- Coverage    97.18%   95.87%   -1.32%     
===========================================
  Files          153      156       +3     
  Lines         7008     7104      +96     
  Branches       514      524      +10     
===========================================
  Hits          6811     6811              
- Misses         156      252      +96     
  Partials        41       41              
Impacted Files Coverage Δ
aws_lambda_powertools/metrics/provider/__init__.py 0.00% <0.00%> (ø)
aws_lambda_powertools/metrics/provider/base.py 0.00% <0.00%> (ø)
...ertools/metrics/provider/datadog_provider_draft.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roger-zhangg
Copy link
Member Author

Closing this one to use the original PR #2194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality metrics size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants