fix(event_handler): allow event source data class events #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Allow for event being of type 'BaseProxyEvent' - Add test case closes aws-powertools#1152
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## develop #1159 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5378 5380 +2
Branches 613 614 +1
========================================
+ Hits 5376 5378 +2
Partials 2 2
Continue to review full report at Codecov.
|
pull-request-size
bot
added
size/M
heitorlessa
approved these changes
Apr 28, 2022
heitorlessa
changed the title
heitorlessa
added a commit
that referenced
this pull request
Apr 28, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(event_handler): Allow for event_source support (#1159)
heitorlessa
added a commit
to ran-isenberg/aws-lambda-powertools-python
that referenced
this pull request
May 18, 2022
* develop: (33 commits) fix(docs): remove Slack link (aws-powertools#1210) docs(roadmap): add new roadmap section (aws-powertools#1204) fix(batch): missing space in BatchProcessingError message (aws-powertools#1201) fix(batch): docstring fix for success_handler() record parameter (aws-powertools#1202) chore(deps): bump email-validator from 1.1.3 to 1.2.1 (aws-powertools#1199) docs(layer): upgrade to 1.25.10 chore: include regression in changelog chore: bump to 1.25.10 feat(parameters): add clear_cache method for providers (aws-powertools#1194) chore(ci): changelog pre-generation to fetch tags from origin revert(parser): Add missing fields for SESEvent (aws-powertools#1027) (aws-powertools#1190) fix(parser): Add missing fields for SESEvent (aws-powertools#1027) fix(data-classes): Add missing SES fields and (aws-powertools#1045) fix(event_handler): exception_handler to handle ServiceError exceptions (aws-powertools#1160) chore(deps-dev): bump flake8-bugbear from 22.1.11 to 22.4.25 (aws-powertools#1156) chore(deps-dev): bump mypy from 0.942 to 0.950 (aws-powertools#1162) chore(deps-dev): bump flake8-eradicate from 1.2.0 to 1.2.1 (aws-powertools#1158) chore(deps): bump github/codeql-action from 1 to 2 (aws-powertools#1154) chore(ci): post release on tagged issues too fix(event_handler): Allow for event_source support (aws-powertools#1159) ...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
Changes
Changes:
User experience
Code like this would no longer raise a type error
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.