fix: Handle missing PageId in metadata when page is resumed #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adebayor123
reviewed
Mar 16, 2023
| @@ -108,6 +108,13 @@ export class PageManager { | |||
| } else if (this.page.pageId !== pageId) { | |||
| this.createNextPage(this.page, pageId); | |||
| } else { | |||
There was a problem hiding this comment.
Nevermind - it seems we want to short circuit
adebayor123
reviewed
Mar 16, 2023
| ); | ||
| }); | ||
|
|
||
| test('when session resumes and page is manually recorded with custom page attributes then custom page attributes are restored', async () => { |
qhanam
reviewed
Mar 16, 2023
adebayor123
approved these changes
Mar 16, 2023
qhanam
approved these changes
Mar 16, 2023
Co-authored-by: Quinn Hanam <qhanam@gmail.com>
ps863
added a commit
to ps863/aws-rum-web
that referenced
this pull request
Mar 17, 2023
…rvability#388) Co-authored-by: Quinn Hanam <qhanam@gmail.com> --------- Co-authored-by: Quinn Hanam <qhanam@gmail.com>
ps863
added a commit
that referenced
this pull request
Mar 17, 2023
Co-authored-by: Quinn Hanam <qhanam@gmail.com> --------- Co-authored-by: Quinn Hanam <qhanam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains a patch based on customer reported issue, wherein, pageId was missing from the metadata of certain events.
In a previous change we changed the behavior of when a Page View event is recorded. In cases where page views resume (this includes resumed sessions and page being reloaded) but page ID is same were changed from being recorded as a separate page view event for each reload/resume to only creating a new page view event only when there was a change in the pageId. However, the change failed to address the following:
This change addresses this by:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.