fix: Update version during release workflow only #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limhjgrace
approved these changes
Feb 23, 2023
ps863
approved these changes
Feb 23, 2023
ps863
pushed a commit
that referenced
this pull request
Feb 24, 2023
Merged
ps863
pushed a commit
that referenced
this pull request
Feb 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
update-version.shis not packaged for NPM, thebuild:versionscript causes builds to fail. Further, we shouldn't be running bash scripts during the build process because they will not execute in all environments (e.g., Windows).This change removes the
build:versionstep from the build process. Instead, this change (1) creates a dummy "version" file which fulfills the build requirement for development builds, and (2) moves the step to the (GitHub Actions) release workflow so the correct version will be set only prior to release.The release workflow works and the bundle contains the correct version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.