-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:referrer #327
Merged
Merged
feat:referrer #327
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b93f349
feat:Referrer
ps863 a6d93aa
Revision 2
ps863 ca4b499
Revision 3
ps863 2efa934
Adding referrer to metadata instead of event details
ps863 fbc10ac
Updated referrer field names with new convention
ps863 5a1190d
Updated referrer field names with new convention
ps863 4e283df
handle localhost referrer
ps863 b251bde
Revert metadata changes
ps863 e05dbd5
Handle localhost
ps863 f2f5fc2
Address comments
ps863 72bee17
remove unneeded import
ps863 9a52c10
Adding localhost unit test for referrer
ps863 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,8 @@ const record = jest.fn(); | |
declare const jsdom: any; | ||
|
||
Object.defineProperty(document, 'referrer', { | ||
value: 'https://console.aws.amazon.com' | ||
value: 'https://console.aws.amazon.com', | ||
configurable: true | ||
}); | ||
Object.defineProperty(document, 'title', { value: 'Amazon AWS Console' }); | ||
global.fetch = mockFetch; | ||
|
@@ -487,3 +488,116 @@ describe('PageManager tests', () => { | |
expect(pageManager.getPage().start).toEqual(2500); | ||
}); | ||
}); | ||
|
||
test('when complete referrer is available from the DOM then is recorded in page view event', async () => { | ||
// Init | ||
const config: Config = { | ||
...DEFAULT_CONFIG, | ||
allowCookies: true | ||
}; | ||
const pageManager: PageManager = new PageManager(config, record); | ||
|
||
Object.defineProperty(document, 'referrer', { | ||
value: 'http://abc.com/consoles', | ||
configurable: true | ||
}); | ||
|
||
// Run | ||
pageManager.recordPageView('/console/home'); | ||
|
||
// Assert | ||
expect(pageManager.getPage()).toMatchObject({ | ||
referrer: 'http://abc.com/consoles', | ||
referrerDomain: 'abc.com', | ||
pageId: '/console/home' | ||
}); | ||
|
||
window.removeEventListener( | ||
'popstate', | ||
(pageManager as any).popstateListener | ||
); | ||
}); | ||
|
||
test('when only domain level referrer is available from the DOM then is recorded in page view event', async () => { | ||
// Init | ||
const config: Config = { | ||
...DEFAULT_CONFIG, | ||
allowCookies: true | ||
}; | ||
const pageManager: PageManager = new PageManager(config, record); | ||
|
||
Object.defineProperty(document, 'referrer', { | ||
value: 'http://abc.com', | ||
configurable: true | ||
}); | ||
// Run | ||
pageManager.recordPageView('/console/home'); | ||
|
||
// Assert | ||
expect(pageManager.getPage()).toMatchObject({ | ||
referrer: 'http://abc.com', | ||
referrerDomain: 'abc.com', | ||
pageId: '/console/home' | ||
}); | ||
|
||
window.removeEventListener( | ||
'popstate', | ||
(pageManager as any).popstateListener | ||
); | ||
}); | ||
|
||
test('when referrer from the DOM is empty then it is recorded as empty in the page view event', async () => { | ||
// Init | ||
const config: Config = { | ||
...DEFAULT_CONFIG, | ||
allowCookies: true | ||
}; | ||
const pageManager: PageManager = new PageManager(config, record); | ||
|
||
Object.defineProperty(document, 'referrer', { | ||
value: '', | ||
configurable: true | ||
}); | ||
// Run | ||
pageManager.recordPageView('/console/home'); | ||
|
||
// Assert | ||
expect(pageManager.getPage()).toMatchObject({ | ||
pageId: '/console/home', | ||
referrer: '', | ||
referrerDomain: '' | ||
}); | ||
|
||
window.removeEventListener( | ||
'popstate', | ||
(pageManager as any).popstateListener | ||
); | ||
}); | ||
|
||
test('when referrer from the DOM is localhost then referrerDomain is also recorded as localhost', async () => { | ||
// Init | ||
const config: Config = { | ||
...DEFAULT_CONFIG, | ||
allowCookies: true | ||
}; | ||
const pageManager: PageManager = new PageManager(config, record); | ||
|
||
Object.defineProperty(document, 'referrer', { | ||
value: 'localhost', | ||
configurable: true | ||
}); | ||
// Run | ||
pageManager.recordPageView('/console/home'); | ||
|
||
// Assert | ||
expect(pageManager.getPage()).toMatchObject({ | ||
pageId: '/console/home', | ||
referrer: 'localhost', | ||
referrerDomain: 'localhost' | ||
}); | ||
|
||
window.removeEventListener( | ||
'popstate', | ||
(pageManager as any).popstateListener | ||
); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: do we need a unit test for when There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. handled in next revision |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Consider covering these (localhost and empty referrer) with unit tests.