Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove duplicate PageIdFormat type in orchestration #162

Merged
merged 1 commit into from
May 19, 2022

Conversation

adebayor123
Copy link
Member

Problem

While merging #156 and #153 , there is a duplicate line of code that initializes PageIdFormat, which is breaking all tests that are run as part of CI.
This PR fixes the issue by removing the duplicate initialization.

Test

Tested on local


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adebayor123 adebayor123 requested a review from qhanam May 19, 2022 16:33
@adebayor123 adebayor123 merged commit 6cec9da into aws-observability:main May 19, 2022
@adebayor123 adebayor123 deleted the fix-bug branch May 19, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants