Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 remove duplicate ts configurations and instead extend #144

Merged
merged 3 commits into from
May 6, 2022

Conversation

maniator
Copy link
Contributor

@maniator maniator commented May 4, 2022

tsconfigs can extend from each other

Now if one is updated, the others also will be updated (if need be) based off changes from the root tsconfig


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maniator
Copy link
Contributor Author

maniator commented May 6, 2022

Hmmm

I can fix the prettier issues

That's why it's better for it to be auto fixed on pre-commit for the most part...

Copy link
Member

@qhanam qhanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you!

@qhanam qhanam merged commit 59947fc into aws-observability:main May 6, 2022
@maniator maniator deleted the tsconfig branch May 6, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants