Skip to content

Commit

Permalink
Update opentelemetry-lambda sub module (#906)
Browse files Browse the repository at this point in the history
* Initial commit to update sub module

* Update manager and collector.go patches

* Modify java patch
  • Loading branch information
vasireddy99 authored Apr 30, 2024
1 parent 992d252 commit f70c255
Show file tree
Hide file tree
Showing 10 changed files with 387 additions and 649 deletions.
2 changes: 1 addition & 1 deletion adot/collector/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v0.35.0
v0.39.0
11 changes: 0 additions & 11 deletions adot/collector/lambdacomponents/default.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ package lambdacomponents
//github.com/aws-observability/aws-otel-lambda/adot/collector/lambdacomponents

import (
"log"

"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter"
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsxrayexporter"
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusremotewriteexporter"
Expand All @@ -29,7 +27,6 @@ import (
"go.opentelemetry.io/collector/exporter/otlpexporter"
"go.opentelemetry.io/collector/exporter/otlphttpexporter"
"go.opentelemetry.io/collector/extension"
"go.opentelemetry.io/collector/featuregate"
"go.opentelemetry.io/collector/otelcol"
"go.opentelemetry.io/collector/receiver"
"go.opentelemetry.io/collector/receiver/otlpreceiver"
Expand Down Expand Up @@ -76,13 +73,5 @@ func Components() (
Exporters: exporters,
}

// TODO: remove after ADOT Collector v0.30.0 is released
if err := featuregate.GlobalRegistry().Set("pkg.translator.prometheus.NormalizeName", false); err != nil {
return otelcol.Factories{}, err
}
log.Printf("attn: users of the prometheusremotewrite exporter please refer to " +
"https://github.com/aws-observability/aws-otel-collector/issues/2043 in regards to an ADOT Collector v0.31.0 " +
"breaking change")

return factories, errs
}
17 changes: 9 additions & 8 deletions adot/collector/lambdacomponents/default_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package lambdacomponents
//github.com/aws-observability/aws-otel-lambda/adot/collector/lambdacomponents

import (
"go.opentelemetry.io/collector/component"
"testing"

"github.com/stretchr/testify/assert"
Expand All @@ -35,22 +36,22 @@ func TestComponents(t *testing.T) {
exporters := factories.Exporters
assert.Len(t, exporters, exportersCount)
// aws exporters
assert.NotNil(t, exporters["awsxray"])
assert.NotNil(t, exporters["awsemf"])
assert.NotNil(t, exporters[component.MustNewType("awsxray")])
assert.NotNil(t, exporters[component.MustNewType("awsemf")])
// core exporters
assert.NotNil(t, exporters["logging"])
assert.NotNil(t, exporters["otlp"])
assert.NotNil(t, exporters["otlphttp"])
assert.NotNil(t, exporters[component.MustNewType("logging")])
assert.NotNil(t, exporters[component.MustNewType("otlp")])
assert.NotNil(t, exporters[component.MustNewType("otlphttp")])
// other exporters
assert.NotNil(t, exporters["prometheusremotewrite"])
assert.NotNil(t, exporters[component.MustNewType("prometheusremotewrite")])

receivers := factories.Receivers
assert.Len(t, receivers, receiversCount)
// core receivers
assert.NotNil(t, receivers["otlp"])
assert.NotNil(t, receivers[component.MustNewType("otlp")])

extensions := factories.Extensions
assert.Len(t, extensions, extensionsCount)
// aws extensions
assert.NotNil(t, extensions["sigv4auth"])
assert.NotNil(t, extensions[component.MustNewType("sigv4auth")])
}
215 changes: 108 additions & 107 deletions adot/collector/lambdacomponents/go.mod

Large diffs are not rendered by default.

722 changes: 226 additions & 496 deletions adot/collector/lambdacomponents/go.sum

Large diffs are not rendered by default.

23 changes: 12 additions & 11 deletions collector.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/collector/internal/collector/collector.go b/collector/internal/collector/collector.go
index 7cdea69..553e649 100644
index 35aaa18..46af9b7 100644
--- a/collector/internal/collector/collector.go
+++ b/collector/internal/collector/collector.go
@@ -26,6 +26,7 @@ import (
Expand All @@ -10,23 +10,24 @@ index 7cdea69..553e649 100644
"go.opentelemetry.io/collector/confmap/provider/yamlprovider"
"go.opentelemetry.io/collector/otelcol"
"go.uber.org/zap"
@@ -57,7 +58,14 @@ func getConfig(logger *zap.Logger) string {

@@ -59,7 +60,15 @@ func getConfig(logger *zap.Logger) string {
func NewCollector(logger *zap.Logger, factories otelcol.Factories, version string) *Collector {
l := logger.Named("NewCollector")
- providers := []confmap.Provider{fileprovider.New(), envprovider.New(), yamlprovider.New(), httpprovider.New(), s3provider.New()}
providerSettings := confmap.ProviderSettings{Logger: l}
- providers := []confmap.Provider{fileprovider.NewWithSettings(providerSettings), envprovider.NewWithSettings(providerSettings), yamlprovider.NewWithSettings(providerSettings), httpprovider.NewWithSettings(providerSettings), s3provider.New()}
+ providers := []confmap.Provider{
+ fileprovider.New(),
+ envprovider.New(),
+ yamlprovider.New(),
+ httpprovider.New(),
+ fileprovider.NewWithSettings(providerSettings),
+ envprovider.NewWithSettings(providerSettings),
+ yamlprovider.NewWithSettings(providerSettings),
+ httpprovider.NewWithSettings(providerSettings),
+ httpsprovider.NewWithSettings(providerSettings),
+ s3provider.New(),
+ httpsprovider.New(),
+ }
+
mapProvider := make(map[string]confmap.Provider, len(providers))

for _, provider := range providers {
@@ -89,8 +97,8 @@ func NewCollector(logger *zap.Logger, factories otelcol.Factories, version strin
@@ -93,8 +102,8 @@ func NewCollector(logger *zap.Logger, factories otelcol.Factories, version strin
func (c *Collector) Start(ctx context.Context) error {
params := otelcol.CollectorSettings{
BuildInfo: component.BuildInfo{
Expand Down
20 changes: 18 additions & 2 deletions manager.patch
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@
diff --git a/collector/internal/lifecycle/manager.go b/collector/internal/lifecycle/manager.go
index 5ec1b6a..d7bf7d2 100644
index 68f6939..2f8ab1e 100644
--- a/collector/internal/lifecycle/manager.go
+++ b/collector/internal/lifecycle/manager.go
@@ -90,7 +90,7 @@
@@ -17,13 +17,14 @@ package lifecycle
import (
"context"
"fmt"
- "github.com/open-telemetry/opentelemetry-lambda/collector/lambdalifecycle"
"os"
"os/signal"
"path/filepath"
"sync"
"syscall"

+ "github.com/open-telemetry/opentelemetry-lambda/collector/lambdalifecycle"
+
"go.uber.org/multierr"
"go.uber.org/zap"

@@ -92,7 +93,7 @@ func NewManager(ctx context.Context, logger *zap.Logger, version string) (contex
}
}()

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-lambda
Submodule opentelemetry-lambda updated 68 files
+4 −0 .github/dependabot.yml
+2 −2 .github/workflows/ci-collector.yml
+1 −1 .github/workflows/codeql.yml
+1 −1 .github/workflows/release-layer-collector.yml
+1 −1 .github/workflows/release-layer-java.yml
+1 −1 .github/workflows/release-layer-ruby.yml
+1 −1 collector/Makefile.Common
+12 −54 collector/README.md
+119 −118 collector/go.mod
+248 −333 collector/go.sum
+6 −2 collector/internal/collector/collector.go
+11 −0 collector/internal/confmap/converter/decoupleafterbatchconverter/README.md
+118 −0 collector/internal/confmap/converter/decoupleafterbatchconverter/converter.go
+153 −0 collector/internal/confmap/converter/decoupleafterbatchconverter/converter_test.go
+2 −1 collector/internal/confmap/converter/disablequeuedretryconverter/converter.go
+4 −4 collector/internal/tools/go.mod
+9 −9 collector/internal/tools/go.sum
+111 −112 collector/lambdacomponents/go.mod
+238 −323 collector/lambdacomponents/go.sum
+1 −1 collector/lambdalifecycle/go.mod
+1 −1 collector/processor/coldstartprocessor/factory.go
+1 −1 collector/processor/coldstartprocessor/factory_test.go
+34 −24 collector/processor/coldstartprocessor/go.mod
+71 −135 collector/processor/coldstartprocessor/go.sum
+16 −5 collector/processor/decoupleprocessor/README.md
+5 −4 collector/processor/decoupleprocessor/config_test.go
+1 −1 collector/processor/decoupleprocessor/factory.go
+3 −2 collector/processor/decoupleprocessor/factory_test.go
+33 −23 collector/processor/decoupleprocessor/go.mod
+68 −70 collector/processor/decoupleprocessor/go.sum
+1 −1 collector/receiver/telemetryapireceiver/factory.go
+1 −1 collector/receiver/telemetryapireceiver/factory_test.go
+33 −24 collector/receiver/telemetryapireceiver/go.mod
+71 −50 collector/receiver/telemetryapireceiver/go.sum
+4 −4 go/sample-apps/function/go.mod
+14 −9 go/sample-apps/function/go.sum
+17 −0 java/README.md
+7 −5 java/dependencyManagement/build.gradle.kts
+30 −1 java/layer-javaagent/scripts/otel-handler
+1 −1 java/layer-wrapper/build.gradle.kts
+6 −0 java/layer-wrapper/scripts/otel-handler
+6 −0 java/layer-wrapper/scripts/otel-proxy-handler
+6 −0 java/layer-wrapper/scripts/otel-sqs-handler
+6 −0 java/layer-wrapper/scripts/otel-stream-handler
+8 −0 java/sample-apps/aws-sdk/README.md
+1 −1 java/sample-apps/aws-sdk/deploy/agent/main.tf
+6 −0 java/sample-apps/aws-sdk/deploy/agent/variables.tf
+1 −1 java/sample-apps/aws-sdk/deploy/wrapper/main.tf
+6 −0 java/sample-apps/aws-sdk/deploy/wrapper/variables.tf
+8 −0 java/sample-apps/okhttp/README.md
+1 −1 java/sample-apps/okhttp/deploy/wrapper/main.tf
+6 −0 java/sample-apps/okhttp/deploy/wrapper/variables.tf
+8 −0 java/sample-apps/sqs/README.md
+1 −1 java/sample-apps/sqs/deploy/agent/main.tf
+6 −0 java/sample-apps/sqs/deploy/agent/variables.tf
+1 −1 java/sample-apps/sqs/deploy/wrapper/main.tf
+6 −0 java/sample-apps/sqs/deploy/wrapper/variables.tf
+6 −6 nodejs/package.json
+18 −18 nodejs/packages/layer/package.json
+6 −0 nodejs/packages/layer/scripts/otel-handler
+4 −4 nodejs/sample-apps/aws-sdk/package.json
+1 −1 python/sample-apps/run.sh
+8 −0 python/src/otel/otel_sdk/otel-instrument
+30 −30 python/src/otel/otel_sdk/requirements-nodeps.txt
+4 −4 python/src/otel/otel_sdk/requirements.txt
+2 −2 python/src/otel/tests/requirements.txt
+1 −1 python/src/otel/tests/test_otel.py
+1 −2 utils/sam/run.sh
5 changes: 1 addition & 4 deletions patch-upstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ if [ -f $PATCH_OTEL_VERSION ]; then
patch -p2 < $PATCH_OTEL_VERSION;
fi



# patch collector startup to remove HTTP and S3 confmap providers
# and set ADOT-specific BuildInfo
# patch collector startup to add httpsprovider
patch -p2 < ../../collector.patch

# patch manager.go to remove lambdacomponents attribute
Expand Down
19 changes: 11 additions & 8 deletions patches/opentelemetry-lambda_java.patch
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,27 @@ index 3e862e7..d3941ac 100644
}

diff --git a/java/dependencyManagement/build.gradle.kts b/java/dependencyManagement/build.gradle.kts
index 2d5f860..cceb485 100644
index f1241db..6bca2dc 100644
--- a/java/dependencyManagement/build.gradle.kts
+++ b/java/dependencyManagement/build.gradle.kts
@@ -9,7 +9,7 @@ plugins {
data class DependencySet(val group: String, val version: String, val modules: List<String>)

val DEPENDENCY_BOMS = listOf(
- "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:2.0.0-alpha",
- "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:2.3.0-alpha",
+ "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:1.32.0-adot-lambda1-alpha",
"org.apache.logging.log4j:log4j-bom:2.22.1",
"software.amazon.awssdk:bom:2.24.2"
"org.apache.logging.log4j:log4j-bom:2.23.1",
"software.amazon.awssdk:bom:2.25.35"
)
@@ -18,7 +18,7 @@ val DEPENDENCIES = listOf(
@@ -18,9 +18,9 @@ val DEPENDENCIES = listOf(
"com.amazonaws:aws-lambda-java-core:1.2.3",
"com.amazonaws:aws-lambda-java-events:3.11.4",
"com.amazonaws:aws-lambda-java-events:3.11.5",
"com.squareup.okhttp3:okhttp:4.12.0",
- "io.opentelemetry.javaagent:opentelemetry-javaagent:2.0.0"
+ "io.opentelemetry.javaagent:opentelemetry-javaagent:1.32.0-adot-lambda1"
- "io.opentelemetry.javaagent:opentelemetry-javaagent:2.3.0",
+ "io.opentelemetry.javaagent:opentelemetry-javaagent:1.32.0-adot-lambda1",
"io.opentelemetry:opentelemetry-sdk-extension-aws:1.19.0",
- "io.opentelemetry.contrib:opentelemetry-aws-resources:1.35.0-alpha",
+ "io.opentelemetry.contrib:opentelemetry-aws-resources:1.32.0-alpha",
)

javaPlatform {

0 comments on commit f70c255

Please sign in to comment.