Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRUM 193] User should not login again when they have already logged in #55

Conversation

poyang1024
Copy link
Collaborator

@poyang1024 poyang1024 commented Jan 24, 2025

Description

Type of Change

  • πŸ› Bug Fix (fixes an issue)
  • ✨ New Feature (introduces a new feature)
  • πŸ’„ UI/UX (improves interface or user experience)
  • πŸ”¨ Refactor (code refactoring)
  • πŸ“ Documentation (updates documentation)
  • πŸ”§ Configuration (changes configuration)
  • πŸš€ Performance (improves performance)
  • βœ… Test (related to tests)
  • πŸ”’ Security (addresses security concerns)

Related Issues

SCRUM-193

Testing

If the user are already logged into our system, when they click the Let's Get Started, they won't need to login again.

Screenshots/Videos

see the preview

Checklist

  • I have tested these changes.
  • I have updated the relevant documentation.
  • My code adheres to the project’s code standards.
  • I have addressed all console warnings/errors.
  • I have removed all console.log or print() statements.
  • I have added necessary test cases.
  • All existing tests pass.

Additional Notes

…ate navigation link based on authentication status | SCRUM-193
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
email-sender βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 24, 2025 3:28pm

Copy link

netlify bot commented Jan 24, 2025

βœ… Deploy Preview for tpet-dev-aws-educate ready!

Name Link
πŸ”¨ Latest commit 3a1d18a
πŸ” Latest deploy log https://app.netlify.com/sites/tpet-dev-aws-educate/deploys/6793b17fedc33100086c4e13
😎 Deploy Preview https://deploy-preview-55--tpet-dev-aws-educate.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@chungchihhan chungchihhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poyang1024 poyang1024 merged commit e4375ce into dev-new Jan 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants