feat(VFS): Adding logging statements around retrieving Deadline VFS location from environment #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viknith
approved these changes
Oct 16, 2023
…ocation from environment. Adding new DEADLINE_VFS_PATH env var check so FUS3_PATH can be removed Signed-off-by: Nathan Matthews <natmatn@amazon.com>
natmatn
force-pushed
the
natmatn/vfs_env_logging
branch
from
4305911
to
5f822c7
Compare
gahyusuh
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Limited logging info when retrieving Deadline VFS location from environment variables made it unclear where the path was being retrieved from. This made bugs around locating the VFS harder to track down.
What was the solution? (How)
Logging where the VFS path was retrieved from, whether it's the expected environment variable or the hard coded fallback path.
What is the impact of this change?
No impact, purely a logging change.
How was this change tested?
hatch run test
Was this change documented?
No
Is this a breaking change?
No