fix(job_attachment)!: Change osType and source_os names #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The field
osType: OperatingSystemFamily
in job/attachments/manifests is currently being used just to determine how to handle the rootPath (i.e., is it 'posix' or 'windows',) in the API, so it follows more closely with the path mapping rules rather than storage profiles. The fieldosType
in job attachment settings should be renamed to something else, to avoid inconsistencies around the usage ofosType
,osFamily
, and whatever encapsulates 'windows' vs. 'posix' paths.What was the solution? (How)
osType: OperatingSystemFamily
->rootPathFormat: PathFormat
sync_inputs
fromsource_os
tosource_path_format
What is the impact of this change?
The field has a better/less-confusing name.
How was this change tested?
hatch run lint && hatch run test
hatch run integ:test
hatch run test_docker
Was this change documented?
No.
Is this a breaking change?
Yes!