Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename impersonation options to use run-as nomenclature #92

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat!: rename impersonation options to use run-as nomenclature #92

merged 2 commits into from
Nov 10, 2023

Commits on Nov 10, 2023

  1. feat!: rename impersonation options to use run-as nomenclature 

    Summary:
 The Worker Agent refers to the feature of running a job/session as a
user separate from the os-user that under which the agent is running as
the impersonation feature. This 'impersonation' nomenclature, though
accurate as to the mechanics that are implemented, is not consistent
with the naming used in the service. We wish to make the nomenclature
consistent between the agent & service to reduce the probability of
confusion.

Solution:
 We change:
1. Configuration file's "[os] impersonation" option to "[os] jobs_run_as_agent_user".
   Impersonation had a default of true whereas the new option has a default of true;
   this is equivalent functionality.
   a. (BREAKING CHANGE) Providing the "impersonation" option in a
      configuration file is now an error.
2. (BREAKIN CHANGE) The environment variable to set whether
   "impersonation" is used was renamed from DEADLINE_WORKER_IMPERSONATION to
   DEADLINE_WORKER_JOBS_RUN_AS_AGENT_USER, and its value is inverted.
   "true" now means that we runs jobs as the agent user whereas it meant
   to run jobs as the Queue's jobsRunAsUser before.
3. The --jobs-run-as-agent-user CLI option was added, and the
   --no-impersonation option has been deprecated to be removed in a
   future release. The two options are mutually exclusive.

Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
    @ddneilson
    ddneilson committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    8ae1752 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>

Co-authored-by: Josh Usiskin <56369778+jusiskin@users.noreply.github.com>
    @ddneilson @jusiskin
    ddneilson and jusiskin authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f27ec2c View commit details
    Browse the repository at this point in the history