feat: print versions of 1st party dependencies to worker log #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When diagnosing issues it can be useful to have the versions of the `deadline` and `openjd-sessions` packages available in the log. This commit adds that information. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
ddneilson/16670
branch
from
edb688e
to
b2ac38e
Compare
ddneilson
commented
Nov 8, 2023
| @@ -19,6 +19,10 @@ class FakeSessionUser(SessionUser): | |||
| def __init__(self, user: str): | |||
| self.user = user | |||
|
|
|||
| @staticmethod | |||
| def get_process_user() -> str: | |||
There was a problem hiding this comment.
Turns out that there was an API break in the -sessions module, but we didn't spot it in code review. So, we have a patch release of that module that breaks the agent tests.
AWS-Samuel
approved these changes
Nov 8, 2023
jusiskin
approved these changes
Nov 8, 2023
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
When diagnosing issues it can be useful to have the versions of the `deadline` and `openjd-sessions` packages available in the log. This commit adds that information. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
When diagnosing issues it can be useful to have the versions of the `deadline` and `openjd-sessions` packages available in the log. This commit adds that information. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Samuel Anderson <119458760+AWS-Samuel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When diagnosing issues it can be useful to have the versions of the
deadlineandopenjd-sessionspackages available in the log.What was the solution? (How)
Import the version numbers of the job attachments, model, and sessions libraries and add them to the log header that we print out at the start of the worker logs.
What is the impact of this change?
More information available in logs.
How was this change tested?
Just running the tests.
Was this change documented?
No
Is this a breaking change?
No