Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update worker binary to deadline-worker-agent where necessary #7

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

mwiebe
Copy link
Contributor

@mwiebe mwiebe commented Aug 27, 2023

What was the problem/requirement? (What/Why)

Worker agent fails to start in the service. We identified that it's trying to run the binary deadline_worker_agent instead of deadline-worker-agent.

What was the solution? (How)

Correct occurrences from deadline_worker_agent to deadline-worker-agent.

What is the impact of this change?

We're one step closer to a working service again.

How was this change tested?

Not tested.

Was this change documented?

No

Is this a breaking change?

It's an unbreaking change.

@mwiebe mwiebe requested a review from a team as a code owner August 27, 2023 21:55
@ddneilson
Copy link
Contributor

Bypassing 2 reviewer requirement. The change is a simple find/replace, and progress is blocked without this change.

@ddneilson ddneilson merged commit 044f0fa into mainline Aug 27, 2023
4 checks passed
@ddneilson ddneilson deleted the markw/fix-worker-binary-name branch August 27, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants