-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add job_run_as_user to integ test #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
jericht
force-pushed
the
jericht/fix_integ
branch
from
October 13, 2023 21:15
6bf4dd6
to
8809eb7
Compare
ddneilson
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this will pass the CIs once the required upstream change is released.
AWS-Samuel
approved these changes
Oct 13, 2023
gmchale79
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
gmchale79
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
gahyusuh
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com> Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com>
gmchale79
pushed a commit
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on releasing aws-deadline/deadline-cloud-test-fixtures#28
What was the problem/requirement? (What/Why)
Queue setting
job_run_as_user
is now required. We need to pass it inWhat was the solution? (How)
Pass it in
What is the impact of this change?
Integ test works again
How was this change tested?
Ran the integ test
Was this change documented?
No
Is this a breaking change?
No
Integ test logs