Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add job_run_as_user to integ test #57

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: add job_run_as_user to integ test #57

merged 1 commit into from
Oct 13, 2023

Conversation

jericht
Copy link
Contributor

@jericht jericht commented Oct 13, 2023 •
edited
Loading

Depends on releasing aws-deadline/deadline-cloud-test-fixtures#28

What was the problem/requirement? (What/Why)

Queue setting job_run_as_user is now required. We need to pass it in

What was the solution? (How)

Pass it in

What is the impact of this change?

Integ test works again

How was this change tested?

Ran the integ test

Was this change documented?

No

Is this a breaking change?

No

Integ test logs

-------------------------------------------------------------------------- live log call --------------------------------------------------------------------------
[2023-10-13 21:13:32,412] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] About to call API (Create job in farm farm-9c8eadc5a20042059813d9c17176774c and queue queue-da251562893345e1ba8529ae2dacaab2)
[2023-10-13 21:13:33,204] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] API call succeeded (Create job in farm farm-9c8eadc5a20042059813d9c17176774c and queue queue-da251562893345e1ba8529ae2dacaab2)
[2023-10-13 21:13:33,204] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Created job: job-1e602de96f504df28b100aeacfba6ac7
[2023-10-13 21:13:33,204] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] About to call API (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:33,323] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] API call succeeded (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:33,324] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Waiting for job job-1e602de96f504df28b100aeacfba6ac7 to complete
[2023-10-13 21:13:33,324] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Waiting for job job-1e602de96f504df28b100aeacfba6ac7 to complete
[2023-10-13 21:13:33,324] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] About to call API (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:33,450] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] API call succeeded (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:33,450] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Job job-1e602de96f504df28b100aeacfba6ac7 not complete
[2023-10-13 21:13:33,450] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Retrying in 10s...
[2023-10-13 21:13:43,457] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] About to call API (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:43,572] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] API call succeeded (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:43,572] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Job job-1e602de96f504df28b100aeacfba6ac7 not complete
[2023-10-13 21:13:43,573] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Retrying in 10s...
[2023-10-13 21:13:53,583] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] About to call API (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:53,745] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] API call succeeded (Fetching job details for job job-1e602de96f504df28b100aeacfba6ac7)
[2023-10-13 21:13:53,746] [test/integ/test_job_submissions.py::TestJobSubmission::test_success] Job result: Job:
id: job-1e602de96f504df28b100aeacfba6ac7
name: Sleep Job
description: None
farm: farm-9c8eadc5a20042059813d9c17176774c
queue: queue-da251562893345e1ba8529ae2dacaab2
template: {"specificationVersion": "jobtemplate-2023-09", "name": "Sleep Job", "steps": [{"name": "Step0", "script": {"actions": {"onRun": {"command": "/bin/sleep", "args": ["5"]}}}}]}
parameters: None
attachments: None
lifecycle_status: CREATE_COMPLETE
lifecycle_status_message: Job creation completed successfully
priority: 98
target_task_run_status: None
task_run_status: SUCCEEDED
task_run_status_counts:
        SUCCEEDED: 1
storage_profile_id: None
max_failed_tasks_count: 100
max_retries_per_task: 5
created_at: 2023-10-13 21:13:32.631000+00:00
created_by: arn:aws:iam::162923712518:user/Admin
updated_at: None
updated_by: None
started_at: 2023-10-13 21:13:40.306000+00:00
ended_at: 2023-10-13 21:13:53.299000+00:00
PASSED                                                                                                                                                      [ 50%]
test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user 
------------------------------------------------------------------------- live log setup --------------------------------------------------------------------------
[2023-10-13 21:13:53,748] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Create queue Queue with jobsRunAsUser job-run-as-user in farm farm-9c8eadc5a20042059813d9c17176774c)
[2023-10-13 21:13:54,431] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Create queue Queue with jobsRunAsUser job-run-as-user in farm farm-9c8eadc5a20042059813d9c17176774c)
[2023-10-13 21:13:54,431] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Created queue: queue-f62558737c044b24aa00638bcd6839ce
[2023-10-13 21:13:54,432] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Create queue-fleet association for queue queue-f62558737c044b24aa00638bcd6839ce and fleet fleet-05378e780ca841b0873abd065af03a66 in farm farm-9c8eadc5a20042059813d9c17176774c)
[2023-10-13 21:13:54,587] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Create queue-fleet association for queue queue-f62558737c044b24aa00638bcd6839ce and fleet fleet-05378e780ca841b0873abd065af03a66 in farm farm-9c8eadc5a20042059813d9c17176774c)
-------------------------------------------------------------------------- live log call --------------------------------------------------------------------------
[2023-10-13 21:13:54,588] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Create job in farm farm-9c8eadc5a20042059813d9c17176774c and queue queue-f62558737c044b24aa00638bcd6839ce)
[2023-10-13 21:13:55,186] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Create job in farm farm-9c8eadc5a20042059813d9c17176774c and queue queue-f62558737c044b24aa00638bcd6839ce)
[2023-10-13 21:13:55,186] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Created job: job-1cab4d6d06e84f93aa302ca9e2c958f4
[2023-10-13 21:13:55,186] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:13:55,307] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:13:55,308] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Waiting for job job-1cab4d6d06e84f93aa302ca9e2c958f4 to complete
[2023-10-13 21:13:55,308] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:13:55,415] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:13:55,416] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Job job-1cab4d6d06e84f93aa302ca9e2c958f4 not complete
[2023-10-13 21:13:55,416] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Retrying in 10s...
[2023-10-13 21:14:05,426] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:14:05,554] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:14:05,554] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Job job-1cab4d6d06e84f93aa302ca9e2c958f4 not complete
[2023-10-13 21:14:05,554] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] Retrying in 10s...
[2023-10-13 21:14:15,561] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:14:15,682] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Fetching job details for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:14:15,693] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Listing sessions for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:14:15,694] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Listing sessions for job job-1cab4d6d06e84f93aa302ca9e2c958f4)
[2023-10-13 21:14:15,823] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] About to call API (Fetching log events for session session-acfce215a6af427489a480773a9ce741 in log group /aws/deadline/farm-9c8eadc5a20042059813d9c17176774c/queue-f62558737c044b24aa00638bcd6839ce)
[2023-10-13 21:14:15,823] [test/integ/test_job_submissions.py::TestJobSubmission::test_jobs_run_as_user] API call succeeded (Fetching log events for session session-acfce215a6af427489a480773a9ce741 in log group /aws/deadline/farm-9c8eadc5a20042059813d9c17176774c/queue-f62558737c044b24aa00638bcd6839ce)
PASSED

@jericht
fix: add job_run_as_user to integ test
8809eb7 
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
@jericht jericht mentioned this pull request Oct 13, 2023
Merged
ddneilson
ddneilson approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@ddneilson ddneilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will pass the CIs once the required upstream change is released.

@jericht jericht marked this pull request as ready for review October 13, 2023 21:50
@jericht jericht requested a review from a team as a code owner October 13, 2023 21:50
@jericht jericht merged commit 962808f into mainline Oct 13, 2023
9 checks passed
@jericht jericht deleted the jericht/fix_integ branch October 13, 2023 22:10
gmchale79 pushed a commit that referenced this pull request Oct 31, 2023
@jericht @gmchale79
fix: add job_run_as_user to integ test (#57)
0a8ad4b 
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
Signed-off-by: Graeme McHale <gmchale@amazon.com>
gmchale79 pushed a commit that referenced this pull request Nov 2, 2023
@jericht @gmchale79
fix: add job_run_as_user to integ test (#57)
6363b44 
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
Signed-off-by: Graeme McHale <gmchale@amazon.com>
gahyusuh pushed a commit that referenced this pull request Nov 6, 2023
@jericht @gahyusuh
fix: add job_run_as_user to integ test (#57)
a506f68 
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
Signed-off-by: Graeme McHale <gmchale@amazon.com>
Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com>
gmchale79 pushed a commit that referenced this pull request Feb 12, 2024
@jericht @gmchale79
fix: add job_run_as_user to integ test (#57)
5a43447 
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
Signed-off-by: Graeme McHale <gmchale@amazon.com>
@client-software-ci client-software-ci mentioned this pull request Feb 22, 2024
Closed
gmchale79 pushed a commit that referenced this pull request Mar 11, 2024
@jericht @gmchale79
fix: add job_run_as_user to integ test (#57)
48ed733 
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddneilson ddneilson ddneilson approved these changes

@AWS-Samuel AWS-Samuel AWS-Samuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jericht @ddneilson @AWS-Samuel