fix!: remove old schema workaround #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service has been updated to the new schema, and the worker agent no longer needs to support the older schema. This completes the work by removing the workaround that allowed the agent to handle both old and new at the same time. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
jusiskin
approved these changes
Sep 15, 2023
karthikbekalp
approved these changes
Sep 15, 2023
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
The service has been updated to the new schema, and the worker agent no longer needs to support the older schema. This completes the work by removing the workaround that allowed the agent to handle both old and new at the same time. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We added a workaround to the agent that would allow it to handle both old job template schema as well as new. This was for a transitory period while the service updated to the new schema. That transition has now been completed, and it's time to remove the workaround.
What was the solution? (How)
Remove the workaround.
What is the impact of this change?
The last vestige of the old schema is removed, and the agent no longer can be used against old versions of the service.
How was this change tested?
Just running our unit tests.
Was this change documented?
N/A
Is this a breaking change?
Yes, technically.