fix: ensure we update job attachments action no matter what #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Worker in closed-beta was crashing before marking a job attachments sync action as failed:
This is because our ojio filter expects the
record.msg
to be astr
, but in reality that filter should be co-ercing the value into a string before using it in a regex.What was the solution? (How)
Newer worker agents have a newer OJIO version that fixes this: https://github.com/casillas2/openjobio/commit/4cba955dfdac38278ff5895fa5c0591f6dbe7550#diff-bfd9934f32ccd128ff1bbb4c62771fbd25e2b739950bca6a4e80bf5163c568f1R130-R133
We also moved to a try/except/finally clause to ensure that the update action happens
What is the impact of this change?
worker agent doesn't stall out indefinitely since it'll actually mark the action as FAILED.
How was this change tested?
Looks like there's no test for this specifically though... if I get some time, I'll add one.
Was this change documented?
N/A
Is this a breaking change?
No