ci: use release environment in release workflow integ tests #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
jusiskin
changed the title
jusiskin
approved these changes
Dec 13, 2023
moorec-aws
approved these changes
Dec 13, 2023
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The new
releaseworkflow failed because the integration test stage to configure AWS credentials failed (see https://github.com/casillas2/deadline-cloud-worker-agent/actions/runs/7188624961/job/19578694519#step:3:10). Root cause of this seems to be that we're referencing areleasesecret environment variable in that stage but we're missing the statement in the workflow file to use thereleaseenvironment.What was the solution? (How)
Use the
releaseenvironment in the integration tests of the release workflowWhat is the impact of this change?
release workflow works
How was this change tested?
N/A / TODO
Was this change documented?
No
Is this a breaking change?
No