-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat!: rename impersonation options to use run-as nomenclature (#92)
* feat!: rename impersonation options to use run-as nomenclature Summary: The Worker Agent refers to the feature of running a job/session as a user separate from the os-user that under which the agent is running as the impersonation feature. This 'impersonation' nomenclature, though accurate as to the mechanics that are implemented, is not consistent with the naming used in the service. We wish to make the nomenclature consistent between the agent & service to reduce the probability of confusion. Solution: We change: 1. Configuration file's "[os] impersonation" option to "[os] jobs_run_as_agent_user". Impersonation had a default of true whereas the new option has a default of true; this is equivalent functionality. a. (BREAKING CHANGE) Providing the "impersonation" option in a configuration file is now an error. 2. (BREAKIN CHANGE) The environment variable to set whether "impersonation" is used was renamed from DEADLINE_WORKER_IMPERSONATION to DEADLINE_WORKER_JOBS_RUN_AS_AGENT_USER, and its value is inverted. "true" now means that we runs jobs as the agent user whereas it meant to run jobs as the Queue's jobsRunAsUser before. 3. The --jobs-run-as-agent-user CLI option was added, and the --no-impersonation option has been deprecated to be removed in a future release. The two options are mutually exclusive. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Co-authored-by: Josh Usiskin <56369778+jusiskin@users.noreply.github.com> --------- Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Co-authored-by: Josh Usiskin <56369778+jusiskin@users.noreply.github.com>
- Loading branch information
Showing
22 changed files
with
190 additions
and
129 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.