Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop using removed worker agent CLI argument #93

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jusiskin
Copy link
Contributor

@jusiskin jusiskin commented Apr 2, 2024

What was the problem/requirement? (What/Why)

  1. The worker agent was modified in feat!: remove deprecated features deadline-cloud-worker-agent#277 to remove deprecate command-line arguments including --allow-instance-profile which is used by the test fixtures.
  2. Standard output from the deadline-worker-agent was redirected to /dev/null which made forensic analysis challenging

What was the solution? (How)

  1. Remove the no-longer-available --allow-instance-profile when launching deadline-worker-agent
  2. Redirect standard output to /tmp/worker-agent-stdout.txt

What is the impact of this change?

The worker agent will startup without errors when running tests which use these test fixtures

How was this change tested?

  • Ran the build
  • E2E tests in progress...

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Josh Usiskin <56369778+jusiskin@users.noreply.github.com>
@jusiskin jusiskin added the bug Something isn't working label Apr 2, 2024
@jusiskin jusiskin requested a review from a team as a code owner April 2, 2024 00:27
@jusiskin jusiskin merged commit f831b92 into mainline Apr 2, 2024
12 checks passed
@jusiskin jusiskin deleted the jusiskin/fix_removed_cli_arg branch April 2, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants