feat!: increase retries for log contains utils #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
jusiskin
previously requested changes
Oct 16, 2024
Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
YutongLi291
changed the title
|
godobyte
approved these changes
Oct 17, 2024
AlexTranAmz
approved these changes
Oct 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
There have been some flaky tests in worker agent E2E tests lately, in which cloudwatch logs take longer than expected to stream after a job is done. This has caused the tests to fail flakily, and is the main reason the canaries fail.
We should make sure the tests themselves are robust and don't fail due to expected delays.
What was the solution? (How)
Increase retries to the number of times we try to get the job logs in the utils.
What is the impact of this change?
Less flaky worker agent e2e tests.
How was this change tested?
hatch run fmthatch run linthatch buildWill monitor after this package is released for flakiness of the worker agent tests.
Was this change documented?
No
Is this a breaking change?
Yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.