feat: allow local session logs to be turned off in worker tests #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
|
leongdl
approved these changes
Oct 15, 2024
leongdl
approved these changes
Oct 15, 2024
jericht
approved these changes
Oct 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
For some of the worker agent tests, we want to verify that local session logs are able to be turned off for the worker agent.
We currently do not have that option in the test fixtures despite it already being an option for the worker agent. We should allow this in the test fixtures.
What was the solution? (How)
Add this as an option in the worker test fixture config
What is the impact of this change?
Further tests are able to spin up a worker that does not write local session logs.
How was this change tested?
hatch run fmthatch run lintWas this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.