Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start service after running the installer instead of during #146

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

YutongLi291
Copy link
Contributor

What was the problem/requirement? (What/Why)

There is an issue with some of the Worker Agent E2E tests in which the task fails with worker agent logs indicating some permission issues. This caused failures with some of the E2E tests.

The issue is possibly that the agent user and the job user are not in a shared posix group. This may be because the agent user isn't in the correct job-user group, due to us starting the worker agent service alongside the installation of the worker agent.

What was the solution? (How)

Start the worker agent service only after the installation of worker, which may fix the issue with the tasks seemingly randomly failing.

The agent user and environment will be setup before the worker agent starts, after this change.

What is the impact of this change?

The WA E2E tests should no longer be as flaky.

How was this change tested?

Tested with this build in the Worker Agent package, and ran

# Linux
source .e2e_linux_infra.sh
hatch run linux-e2e-test
hatch run cross-os-e2e-test

# Windows
source .e2e_windows_infra.sh
hatch run windows-e2e-test
hatch run cross-os-e2e-test

The tests passed, at least against my dev setup.

Was this change documented?

No

Is this a breaking change?

no

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Yutong Li <52769999+YutongLi291@users.noreply.github.com>
@YutongLi291 YutongLi291 requested a review from a team as a code owner August 26, 2024 18:17
Copy link

sonarcloud bot commented Aug 26, 2024

@AWS-Samuel
Copy link
Contributor

Nit, we should title the commit test: ..., so this doesn't show up in the changelog

@AWS-Samuel AWS-Samuel merged commit adac342 into aws-deadline:mainline Aug 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants