fix: start service after running the installer instead of during #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
There is an issue with some of the Worker Agent E2E tests in which the task fails with worker agent logs indicating some permission issues. This caused failures with some of the E2E tests.
The issue is possibly that the agent user and the job user are not in a shared posix group. This may be because the agent user isn't in the correct job-user group, due to us starting the worker agent service alongside the installation of the worker agent.
What was the solution? (How)
Start the worker agent service only after the installation of worker, which may fix the issue with the tasks seemingly randomly failing.
The agent user and environment will be setup before the worker agent starts, after this change.
What is the impact of this change?
The WA E2E tests should no longer be as flaky.
How was this change tested?
Tested with this build in the Worker Agent package, and ran
The tests passed, at least against my dev setup.
Was this change documented?
No
Is this a breaking change?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.