fix: add missing comma to ssm command #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Edwards <edwards@amazon.com>
|
ddneilson
approved these changes
Aug 13, 2024
jusiskin
approved these changes
Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We were missing a comma in an ssm command list. Unfortunately in Python having two string on a separate line in a list is valid syntax and it concats the two lines together.
What was the solution? (How)
Add the missing commas!
What is the impact of this change?
Integ tests pass.
How was this change tested?
I added the new build to the
requirements-test.txtin the deadline worker agent repo. I then made sure the change was in the hatch environment. I ran the linux e2e tests and made sure they passed.Was this change documented?
N/A
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.