Skip to content

Commit

Permalink
Fix tests and linters
Browse files Browse the repository at this point in the history
Signed-off-by: Trevor Blanchard <55503092+ttblanchard@users.noreply.github.com>
  • Loading branch information
ttblanchard committed Jul 4, 2024
1 parent e263b06 commit 4da5101
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions src/deadline_test_fixtures/deadline/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ def configure_worker_command(
@abc.abstractmethod
def get_worker_id(self) -> str:
raise NotImplementedError("'get_worker_id' was not implemented.")

def userdata(self, s3_files) -> str:
raise NotImplementedError("'userdata' was not implemented.")

def start(self) -> None:
s3_files = self._stage_s3_bucket()
Expand Down
3 changes: 2 additions & 1 deletion src/deadline_test_fixtures/fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
PipInstall,
PosixInstanceWorker,
WindowsInstanceWorker,
EC2InstanceWorker,
)
from .models import (
CodeArtifactRepositoryInfo,
Expand Down Expand Up @@ -513,7 +514,7 @@ def ec2_worker_type(request: pytest.FixtureRequest) -> Generator[Type[DeadlineWo
def worker(
request: pytest.FixtureRequest,
worker_config: DeadlineWorkerConfiguration,
ec2_worker_type: Type[DeadlineWorker],
ec2_worker_type: Type[EC2InstanceWorker],
) -> Generator[DeadlineWorker, None, None]:
"""
Gets a DeadlineWorker for use in tests.
Expand Down
2 changes: 1 addition & 1 deletion test/unit/deadline/test_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ def test_get_worker_id(self, worker_id: str, worker: PosixInstanceWorker) -> Non
worker, "send_command", return_value=CommandResult(exit_code=0, stdout=worker_id)
):
# WHEN
result = worker.worker_id()
result = worker.worker_id

# THEN
assert result == worker_id.rstrip("\n\r")
Expand Down

0 comments on commit 4da5101

Please sign in to comment.