changes due to controller-runtime v0.11.0 upgrade #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: unit test is currently failing because prow base image for testing the controller is not using |
ack-bot
pushed a commit
to aws-controllers-k8s/test-infra
that referenced
this pull request
Jan 6, 2022
Description of changes: * This is needed for testing ACK core libraries after controller-runtime dependency update which uses minimum go version 1.17 PR with failing test: aws-controllers-k8s/runtime#63 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
👍 🎉 |
RedbackThomson
approved these changes
Jan 6, 2022
|
/test unit-test |
jaypipes
approved these changes
Jan 6, 2022
|
Let's do it! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RedbackThomson
pushed a commit
to RedbackThomson/ack-test-infra
that referenced
this pull request
Jan 8, 2022
Description of changes: * This is needed for testing ACK core libraries after controller-runtime dependency update which uses minimum go version 1.17 PR with failing test: aws-controllers-k8s/runtime#63 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-controllers-k8s/community#1112
Description of changes:
Reconcilemethod in reconcilers now accepts acontext.ContextparameterACK RuntimeMetaObjectwithcontroller-runtime Objectdesired.RuntimeObject().DeepCopyObject()withdesired.DeepCopy().RuntimeObject()because the former does not return implementation ofcontroller-runtime ObjectRuntimeMetaObject()method from AWSResource interfacecontroller-runtime client Objectinstead ofapimachinery runtime ObjectBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.