Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller-runtime v0.19.0 #159

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Update controller-runtime v0.19.0 #159

merged 1 commit into from
Oct 1, 2024

Conversation

a-hilaly
Copy link
Member

  • Bump Kubernetes related packages to v0.31.0
  • Update controller-runtime to v0.19.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from jlbutler August 29, 2024 06:02
@ack-prow ack-prow bot added the approved label Aug 29, 2024
@a-hilaly
Copy link
Member Author

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@a-hilaly
Copy link
Member Author

/retest

@a-hilaly
Copy link
Member Author

/test all

@a-hilaly
Copy link
Member Author

/test verify-attribution

@a-hilaly a-hilaly changed the title Update Go dependencies and Kubernetes related packages Update controller-runtime v0.19.0 Sep 5, 2024
@a-hilaly
Update Go dependencies and Kubernetes related packages
adf1947 
chore: update dependencies and Go toolchain

- Bump Kubernetes related packages to `v0.31.0`
- Update controller-runtime to `v0.19.0`
@a-hilaly a-hilaly removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 24, 2024 •
edited
Loading

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution adf1947 link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelhtm
michaelhtm approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 064fe3a into aws-controllers-k8s:main Oct 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-hilaly @michaelhtm