Reorder account ID lookup in getOwnerAccountID
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the order of operations in the `getOwnerAccountID` function to prioritize checking namespace annotations over resource status when determining the owner account ID. The new order of checks is: 1. Namespace annotations 2. Resource status (`status.ackResourceMetadata`) 3. Controller's default AWS account
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow bot
pushed a commit
to aws-controllers-k8s/iam-controller
that referenced
this pull request
Aug 1, 2024
Mainly bringing the new bug fixes from runtime to the iam controller: - aws-controllers-k8s/runtime#154 - aws-controllers-k8s/runtime#153 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the order of operations in the
getOwnerAccountIDfunction to prioritize checking namespace annotations over resource
status when determining the owner account ID.
The new order of checks is:
status.ackResourceMetadata)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.